Skip to content

test: remove duplicate test in explicit_push_trigger codemod - #1898

Draft
github-actions[bot] wants to merge 1 commit into
mainfrom
test-reducer-codemods-push-trigger-dup-8cb2e997ad3a2643
Draft

test: remove duplicate test in explicit_push_trigger codemod#1898
github-actions[bot] wants to merge 1 commit into
mainfrom
test-reducer-codemods-push-trigger-dup-8cb2e997ad3a2643

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Warning

Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding.

What happened

The threat detection results could not be parsed.

Review the workflow run logs for details.

Test Suite Reduction: src/compile/codemods/0006_explicit_push_trigger.rs

What was wrong

  • injects_all_branches_push_when_on_absent_in_old_source was an exact duplicate of fires_for_the_release_immediately_before_the_cutover: both build the same context (old_ctx(), i.e. compiler_version: INTRODUCED_IN, source_compiler_version: "0.48.0"), apply the codemod to the identical name: x\ndescription: y\n input, and assert the same outcome (apply_codemod returns true and push_include(&m) == ["*"]). It added no additional coverage beyond the other test.

Changes

Test Action Reason
injects_all_branches_push_when_on_absent_in_old_source Removed Exact duplicate of fires_for_the_release_immediately_before_the_cutover

Verification

  • cargo test --bin ado-aw: all 2947 tests pass ✅ (81 remaining tests in this module, 82 total codemod tests before removal, 82 -1 = 81 after)
  • cargo clippy --all-targets --all-features: no errors/warnings introduced ✅

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • spsprodeus21.vssps.visualstudio.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "spsprodeus21.vssps.visualstudio.com"

See Network Configuration for more information.

Generated by Test Reducer · auto · 92.9 AIC · ⊞ 13.1K ·

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Threat detection produced a warning for this pull request output.

These changes need to be scrutinized before merge and only merged after a careful manual review.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
2 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants