test: remove duplicate test in explicit_push_trigger codemod - #1898
Draft
github-actions[bot] wants to merge 1 commit into
Draft
test: remove duplicate test in explicit_push_trigger codemod#1898github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
There was a problem hiding this comment.
Threat detection produced a warning for this pull request output.
These changes need to be scrutinized before merge and only merged after a careful manual review.
- Detection reason:
parse_error - Review workflow run logs: https://github.com/githubnext/ado-aw/actions/runs/31702276368
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding.
What happened
The threat detection results could not be parsed.
Review the workflow run logs for details.
Test Suite Reduction: src/compile/codemods/0006_explicit_push_trigger.rs
What was wrong
injects_all_branches_push_when_on_absent_in_old_sourcewas an exact duplicate offires_for_the_release_immediately_before_the_cutover: both build the same context (old_ctx(), i.e.compiler_version: INTRODUCED_IN,source_compiler_version: "0.48.0"), apply the codemod to the identicalname: x\ndescription: y\ninput, and assert the same outcome (apply_codemodreturnstrueandpush_include(&m) == ["*"]). It added no additional coverage beyond the other test.Changes
injects_all_branches_push_when_on_absent_in_old_sourcefires_for_the_release_immediately_before_the_cutoverVerification
cargo test --bin ado-aw: all 2947 tests pass ✅ (81 remaining tests in this module, 82 total codemod tests before removal, 82 -1 = 81 after)cargo clippy --all-targets --all-features: no errors/warnings introduced ✅Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
spsprodeus21.vssps.visualstudio.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.