watch multiple directories via --directory flag #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the addition. This seems reasonable! I'll review this tomorrow. |
githubnemo
requested changes
Apr 29, 2020
| @@ -122,6 +121,7 @@ var ( | |||
| flag_verbose = flag.Bool("verbose", false, "Be verbose about which directories are watched.") | |||
|
|
|||
| // initialized in main() due to custom type. | |||
| flag_directories globList | |||
| flag_excludedDirs globList | |||
There was a problem hiding this comment.
This is the only line I have a gripe with.
directories is not a glob list and it never should be. I think we should refactor globList into a more general stringList and let globList build upon it.
Do you want to make that change? Let me know so I can do it instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR provides functionality I needed for a monorepo project, the ability to provide multiple --directory flags which are watched for changes.