Fix Delay Attributes #3
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found character delay and line delay aren't been set correctly even if I provided a valid value.
I think the bug is caused by a typo in the getter function, the minimum of
0
,2_147_483_647
,data-xxx-delay
is the only param of Math.max.So I tried to fix the bug by moving the lower bound out of the calling of Math.min and it seems to work now.
(Please forgive me for my poor English😥)