Space being unavoidably added

[silverwind]

There is an unavoidable space character being appended target element's value during the text-expander-value event:

text-expander-element/src/text-expander-element.ts

Line 128 in 5b5f7ad

const value = `${detail.value} `

Could this be removed or made optional? I think the consumer of the module should be in control of whether they want this space, or not.

[keithamus]

Thanks for the issue! PRs welcome to add the optionality.

[silverwind]

How do you feel about removing it and pushing v3.0.0 with it? I think the proper fix is to remove it instead of working around the issue with an option.

[keithamus]

We’d like to retain the behaviour so if you think it’s undesirable for your usecase, then we can make it an option (eg a suffix attribute which defaults to a space)

[silverwind]

My use case might be something for GitHub to consider too:

• On a @ mention, the space is desirable as one usually starts a sentence.
• On a : emoji, the space is undesirable as it's often used to end a sentence.

A HTML attribute will not work as I need different behaviour per-key, so it needs to be an option that is set before event.detail.value is assigned. I'm thinking about event.detail.options as a options object with default value {suffix: ' '}.

[silverwind]

Actually, a HTML option will work as well when set to the empty string as the optional space can be appended during the event.detail.value assignment based on key, so I'll go for that.