feat: allow user to use github app to authenticate #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmeridth
force-pushed
the
jm-github-app-token
branch
6 times, most recently
from
7cdf1b9 to
8945bf5
Compare
jmeridth
commented
Mar 6, 2024
jmeridth
force-pushed
the
jm-github-app-token
branch
from
8945bf5 to
2fc75a8
Compare
This feature allows users to authenticate with either just a GitHub app or a GitHub App Installation. - [x] setup authentication - [x] helper function to get integer environment variables without ValueError - [x] tests - [x] GitHub App Installation passing - [x] helper function to get integer environment variables - [x] added .venv to flake8 exlusion list (may need to address this another way) - [x] alphabetized lists in places (README, etc) Signed-off-by: jmeridth <jmeridth@gmail.com>
jmeridth
force-pushed
the
jm-github-app-token
branch
from
2fc75a8 to
07e22a2
Compare
|
@zkoppert Curious your thoughts on this one. Could we please give a tests a run. Curious if any diff upstream compared to my local runs. Thank you. |
|
Looking at lint errors. |
Signed-off-by: jmeridth <jmeridth@gmail.com>
Signed-off-by: jmeridth <jmeridth@gmail.com>
|
More linting fixes. In another PR I'm going to get superlinter working with |
zkoppert
reviewed
Mar 8, 2024
Co-authored-by: Zack Koppert <zkoppert@github.com>
zkoppert
approved these changes
Mar 8, 2024
|
Great work! Thanks for adding this! It's got me thinking about all the other actions that could use this 😄 |
|
@zkoppert I was thinking the same. The |
|
@zkoppert Was thinking about keeping it DRY somehow also. 🤔 |
That would be great! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89
Pull Request
Proposed Changes
This feature allows users to authenticate with either just a GitHub app or a GitHub App Installation.
Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducingReviewer
bug,documentation,enhancement,infrastructure, orbreaking