Skip to content

Conversation

@jmeridth
Copy link
Member

@jmeridth jmeridth commented Mar 30, 2024

Pull Request

Proposed Changes

catch up this repo with other ospo github action repo changes

  • update README with split authentication information

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, or breaking

@jmeridth jmeridth added the enhancement New feature or request label Mar 30, 2024
@jmeridth jmeridth self-assigned this Mar 30, 2024
@jmeridth jmeridth requested a review from zkoppert as a code owner March 30, 2024 04:54
@jmeridth jmeridth force-pushed the jm-more-standardization branch from 7b59def to 97b6616 Compare March 30, 2024 04:55
catch up this repo with other ospo github action repo changes

- [x] update README with split authentication information

Signed-off-by: jmeridth <jmeridth@gmail.com>
@jmeridth jmeridth force-pushed the jm-more-standardization branch from 97b6616 to a64eba0 Compare March 30, 2024 05:04
@jmeridth jmeridth changed the title chore: more repo config stuff chore: catch up repo standards Mar 30, 2024
Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@zkoppert
Copy link
Member

zkoppert commented Apr 1, 2024

I'd consider switching the label to documentation instead of enhancement as this doesn't represent a new feature.

@jmeridth jmeridth added documentation Improvements or additions to documentation and removed enhancement New feature or request labels Apr 1, 2024
@jmeridth jmeridth merged commit ba84f48 into github:main Apr 1, 2024
@jmeridth jmeridth deleted the jm-more-standardization branch April 1, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants