Repository navigation
refactor(version): extract shared operation - #4863
Merged
Merged
Conversation
Move version, runtime, platform, and capability collection into a transport-neutral typed operation while preserving the existing CLI adapter contract and patch points. Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The refactor preserves established behavior, compatibility paths, and transport-specific ownership with adequate test coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Extracts version collection into a typed, transport-neutral operation while preserving CLI rendering and compatibility behavior.
Changes:
- Adds typed runtime, system, and capability collection.
- Refactors the CLI adapter to consume shared results.
- Adds operation and adapter coverage.
| File | Description |
|---|---|
src/specify_cli/_operation_version.py |
Implements shared version collection. |
src/specify_cli/command_version.py |
Maps shared results to existing CLI output. |
tests/specify_cli/test_operation_version.py |
Tests operation contracts and probes. |
tests/specify_cli/test_command_version.py |
Tests CLI adapter integration. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
1 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_operation_version.pyapplication entry point for CLI version, runtime, system, and feature capability collectioncommand_version.pyresponsible for Typer registration, Rich rendering, CLI JSON serialization, streams, sanitized failures, and exit codesValidation
uv sync --extra test— passedLC_ALL=en_US.UTF-8 .venv/bin/python -m pytest— 9,742 passed, 19 skipped.venv/bin/python -m pytest tests/specify_cli/test_operation_version.py tests/specify_cli/test_command_version.py— 16 passeduv run ruff check src/specify_cli/_operation_version.py src/specify_cli/command_version.py tests/specify_cli/test_operation_version.py tests/specify_cli/test_command_version.py— passeduv run ruff format --check src/specify_cli/_operation_version.py src/specify_cli/command_version.py tests/specify_cli/test_operation_version.py tests/specify_cli/test_command_version.py— passedgit diff --check— passedScope
No MCP adapter, MCP registration, command inventory, access policy, working-directory behavior, or JSON contract changes are included.
AI disclosure
Implemented with GitHub Copilot using GPT-5.6 Sol in autonomous mode; code generation, tests, validation, commit, and pull request drafting.