Update directives to add manifest-src to Chrome/Firefox
#339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yay! Thanks @carlosantoniodasilva. I can update the changelog. Since master represents the (unreleased) 4.x line, I'll |
|
(leaving this open so I remember to do this next week) |
|
@oreoshake thanks! I totally missed the 3.x branch vs master being 4x. Let me know if you'd prefer a separate PR targeting 3.x or if I can help with anything else! |
|
Don't worry about it! It's not obvious and I'm seriously lagging on
releasing 4.x so this gives me more motivation to do so. Unfortunately, a
kitchen accident 🔪 has made coding temporarily more difficult 😆.
…On Thu, Jul 13, 2017 at 17:02 Carlos Antonio da Silva < ***@***.***> wrote:
@oreoshake <https://github.com/oreoshake> thanks! I totally missed the
3.x branch vs master being 4x. Let me know if you'd prefer a separate PR
targeting 3.x or if I can help with anything else!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#339 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAbYBB5o55bn0WQYYFDZX7THM1mwNmguks5sNq_ugaJpZM4OVwLk>
.
|
oreoshake
approved these changes
Jul 14, 2017
|
Released in 3.6.7! Thanks again. |
|
🎉 thanks so much @oreoshake! And sorry to hear about the 🔪 accident! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #338.
manifest-srcCSP directive to Chrome/Firefoxreflected-xssI also took the opportunity to bump the ruby version to the latest. I did not update the Changelog, let me know if that's necessary and I will.
If you have any questions/considerations, let me know, thanks!