support revisionhistorylimit #869
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for configuring the revisionHistoryLimit field in the Kubernetes deployment for the safe-settings Helm chart, allowing users to control how many old ReplicaSets are retained for rollback purposes.
- Adds a new configurable
revisionHistoryLimitfield to the Helm values - Integrates the revision history limit setting into the deployment template
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| helm/safe-settings/values.yaml | Adds default revisionHistoryLimit value of 10 |
| helm/safe-settings/templates/deployment.yaml | Uses the configurable revision history limit in the deployment spec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.