Type cleanup #26
Merged
Type cleanup #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
`ConfigOptions` was the same type as `ContainerConfig` but with all properties optional. TypeScript's `Partial<>` helper does this for us, simplifying things. Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
This is a much easier name to grok than ContainerConfig, which implies options are bound to each container (which is only incidentally true)! Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
koddsson
approved these changes
Nov 1, 2021
Contributor
koddsson
left a comment
koddsson
left a comment
There was a problem hiding this comment.
Partial<Type> looks to be very useful for option objects like this 👀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a small type cleanup that @khiga8 and I did, which simplifies the types we have in the codebase by using
Partial<>. It also renames the confusingly namedContainerConfigtoOptions. We've also upgraded TypeScript while working on this.This is a small change, there's no real need to release this as it is functionally identical, just a small cleanup.