Skip to content

added input check and usage to git-find-large-files #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 24, 2020
Merged

added input check and usage to git-find-large-files #363

merged 3 commits into from
Aug 24, 2020

Conversation

jefeish
Copy link
Contributor

@jefeish jefeish commented Aug 20, 2020

I ran the git-find-large-files command with a -h 😁 and ended up with ...

./git-find-large-files: line 67: [: -h: integer expression expected
./git-find-large-files: line 67: [: -h: integer expression expected
./git-find-large-files: line 67: [: -h: integer expression expected
...

The added check also prevents negative integers.

@jefeish jefeish requested a review from larsxschneider August 20, 2020 17:25
@jefeish jefeish changed the title added input _check_ and _usage_ to git-find-large-files added input check and usage to git-find-large-files Aug 20, 2020
larsxschneider
larsxschneider approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@larsxschneider larsxschneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you 😊

jefeish and others added 2 commits August 24, 2020 10:13
@jefeish @larsxschneider
Update scripts/git-find-large-files
32b939d 
Co-authored-by: Lars Schneider <larsxschneider@github.com>
@jefeish @larsxschneider
Update scripts/git-find-large-files
6df9d7d 
the 'space' was intentional, to set the statement 'apart' :) ... anyhow removing it

Co-authored-by: Lars Schneider <larsxschneider@github.com>
@jefeish jefeish merged commit 59766bc into master Aug 24, 2020
@stoe stoe deleted the jefeish/patch-1 branch June 7, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliegaudet juliegaudet juliegaudet left review comments

@Sahocan6363 Sahocan6363 Sahocan6363 left review comments

@larsxschneider larsxschneider larsxschneider approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jefeish @larsxschneider @juliegaudet @Sahocan6363