build: update liquid to 4.0.4 #860
Conversation
gradybarrett
force-pushed
the
gradybarrett/liquid-v4-0-4
branch
2 times, most recently
from
1a17219
to
899840d
Compare
|
@parkr hopefully this PR wasn't presumptuous. 😄 |
|
Nope! I can't merge this though since I don't work at GitHub anymore. Perhaps @yoannchaudet can help! This patched version fixes compatibility with Ruby 3.2. |
|
Would be great to have this merged. |
|
This issue is blocking the use of Ruby 3.2 for Github Pages sites. Could someone with the authority to merge it please take a look at it? It's a simple one-line fix. I can corroborate that tests pass with this change. |
Ruby 3.2 removed the "tainted" interface, which liquid >=4.0.3 still uses. Liquid 4.0.4 removes references to this interface that it works with Ruby 3.2. Closes github#859.
gradybarrett
force-pushed
the
gradybarrett/liquid-v4-0-4
branch
from
899840d
to
0ab2e26
Compare
|
Updated the branch and fixed my gpg config. |
|
+1 please merge this in, I've had to explicitly point my blog towards this forked repo |
|
Can confirm this is still a problem, I'm receiving: Any ETA on when this will be merged? |
|
Surfacing that to the team, we will look at it shortly and make a round of update. |
|
@yoannchaudet I'm making a bug patch release of Jekyll soon that allows y'all to also upgrade |
|
Is there any solution in place for this? This error is not allowing me to push any changes to my Jekyll website :) |
|
Same |
|
Hopefully you upgrade the Ruby used by your Jekyll site independently from other apps you maintain! I personally always run CI with any ruby or gem updates before merging. Then I can still push updates to my site while I wait for the update to be compatible. I recommend rbenv for maintaining several different Ruby versions on the same system. |
|
Hey everyone, I'm probably missing something, but after running bundle update github-pages I'm still getting the tainted error. Is there anything else that I need to do to serve my site locally? |
|
The gem has not been fully propagated in the systems. It is being updated today. https://pages.github.com/versions/ will report it as soon as it's there. |
|
We should be good now: https://pages.github.com/versions. Still updating our legacy build infra but build on Actions are already current. |
|
Thank you so much, @yoannchaudet! |
|
Working 100%. Thank you very much @yoannchaudet |
Ruby 3.2 removed the "tainted" interface, which liquid <=4.0.3
still uses. Liquid 4.0.4 removes references to this interface so that
it works with Ruby 3.2.
Closes #859.