Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump rouge to v3.11.0 #652

Merged
merged 2 commits into from
Oct 8, 2019
Merged

Bump rouge to v3.11.0 #652

merged 2 commits into from
Oct 8, 2019

Conversation

pchaigno
Copy link
Contributor

Supersedes #635 and #597.

Fixes #601.

@pchaigno pchaigno changed the title Bump rouge to v3.9.0 Bump rouge to v3.10.0 Sep 3, 2019
@EricFromCanada EricFromCanada mentioned this pull request Sep 10, 2019
Merged
@EricFromCanada
Copy link

Suggest rebasing and updating to rouge v3.11.0 in order to improve the highlighting in the Liquid and Jekyll docs.

@pchaigno
Copy link
Contributor Author

@EricFromCanada Done. I received notifications for now Rouge releases, so I won't miss them :-)

@pchaigno pchaigno changed the title Bump rouge to v3.10.0 Bump rouge to v3.11.0 Sep 19, 2019
@pchaigno
Copy link
Contributor Author

@parkr Did you get a chance to look into this?

@shopmike
Copy link

👍 LGTM

@pchaigno
Copy link
Contributor Author

@parkr Is something needed to merge this pull request? I noticed there are several other such "Bump xxxxx" pull requests you approved but didn't merge.

@parkr
Copy link
Contributor

parkr commented Sep 30, 2019

Is something needed to merge this pull request?

@pchaigno Yes! There is a bunch of automated internal testing that takes time, and some testing that requires human intervention. We try to wait to merge until we've validated the PR in the wild with Pages builds. No promises on timeline, but I'm hoping we can get this merged 🔜 !

@pchaigno
Copy link
Contributor Author

Okay, thanks for the explanation!

@parkr parkr merged commit cbcd1b7 into github:master Oct 8, 2019
This was referenced Oct 8, 2019
Closed
Closed
Closed
@pchaigno pchaigno deleted the bump-rouge branch October 9, 2019 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parkr parkr parkr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Rouge to 3.x
4 participants
@pchaigno @EricFromCanada @shopmike @parkr