Skip to content

ci: reduce permissions on auto-labeler and set to not release #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

jmeridth
Copy link
Member

We were seeing random draft releases after a release occurred. I realized the auto-labeler workflow (also using draft-release action) was still doing a draft release. This was the culprit. By adding disable-releaser: true, we prevent this. Since this workflow no longer needs to create a release we can remove the contents: write permissions also.

  • change image-name from hard-coded to github.repository in test-release

We were seeing random draft releases after a release occurred. I
realized the auto-labeler workflow (also using draft-release action)
was still doing a draft release.  This was the culprit.  By adding
`disable-releaser: true`, we prevent this.  Since this workflow no
longer needs to create a release we can remove the `contents: write`
permissions also.

- [x] change image-name from hard-coded to github.repository in test-release

Signed-off-by: jmeridth <jmeridth@gmail.com>
@jmeridth jmeridth self-assigned this Jan 25, 2025
@Copilot Copilot AI review requested due to automatic review settings January 25, 2025 09:09
@jmeridth jmeridth requested a review from a team as a code owner January 25, 2025 09:09
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

@jmeridth jmeridth merged commit b89c534 into main Jan 25, 2025
9 checks passed
@jmeridth jmeridth deleted the jm_change_perms_for_autolabeler branch January 25, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant