Skip to content

Add CONTRIBUTING.md #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 31, 2016
Merged

Add CONTRIBUTING.md #85

merged 3 commits into from
Aug 31, 2016

Conversation

nayafia
Copy link
Contributor

@nayafia nayafia commented Aug 29, 2016

First pass on writing up CONTRIBUTING.md, which should 1) explain the goals of this project and 2) help people figure out how to contribute.

Couple of things I'd like input on before merging:

  1. Are there any contributions we explicitly DON'T want? (ex. design or code)
  2. Do we have any test requirements for contributors?
  3. Do we need to include a section about bug reports or security disclosures? (Since this is primarily content, I wasn't sure)
  4. Community Review and Community sections - am I being too aggressive/not nice about keeping communication public, etc? any recommendations for softening language?

cc @bkeepers for qs 1-4
@stephbwills for q4 and overall input on tone/friendliness

@nayafia
Copy link
Contributor Author

nayafia commented Aug 29, 2016

Per https://github.com/github/open-source-handbook/issues/81, checks are failing but I think we're ok, right?


* **Approachability:** Don't assume reader has prior knowledge
* **Brevity:** Keep it simple, link to outside content for deeper dives
* **Curation:** Amplify community best practices vs. any individual's POV

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

POV point of view

@bkeepers
Copy link

Are there any contributions we explicitly DON'T want? (ex. design or code)

If we end up serving the content from github.com/open-source we may become more restrictive with design, but as long as it's a stand-alone jekyll site, I'm actually curious to see what all people will contribute. What do you think?

@mlinksva The current license doesn't say anything about the styles and design. Thoughts?

Do we have any test requirements for contributors?

They shouldn't have to modify any tests. They may need to pay attention to test failures (after switching to Travis CI - #87). If we get spelling (#63) or any other more strict tests, we may need people to add new terms to a dictionary.

Do we need to include a section about bug reports or security disclosures? (Since this is primarily content, I wasn't sure)

I don't think so.

Community Review and Community sections - am I being too aggressive/not nice about keeping communication public, etc? any recommendations for softening language?

👍 for being explicit about keeping communication public. I'll comment on specific lines below.

Per #81, checks are failing but I think we're ok, right?

Looks like it's fixed now.

@mlinksva
Copy link
Contributor

CSS falls under code I'd think.


## Goals of this project

We created this Handbook for individuals, communities and companies that want to successfully run and maintain an open source project. The content was originally created and curated by GitHub, along with input from outside community reviewers, but it is not specific to GitHub products.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

communities and companies -> communities, and companies

* **Brevity:** Keep it simple, link to outside content for deeper dives
* **Curation:** Amplify community best practices vs. any individual's POV

This Handbook is a jumping off point for people who want to familiarize themselves with running an open source project. It should give readers enough information to get started, but it doesn't attempt to answer everything in detail.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Handbook is a jumping off point for people who want to familiarize themselves with running an open source project.

Is there a simpler way to say this? Maybe?

This Handbook is a jumping off point for people who want to learn how to run an open source project.


This Handbook is a jumping off point for people who want to familiarize themselves with running an open source project. It should give readers enough information to get started, but it doesn't attempt to answer everything in detail.

This Handbook also aggregates community best practices, *not* what GitHub (or any other individual or entity) thinks is best. Therefore, we try to use examples and quotations from others to illustrate our points. Many sections also link to "Further Reading" at the end, to surface relevant writing and perspectives that lives elsewhere on the web.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lives -> live


Interested in making a contribution? Read on!

(should we call out anything we're NOT looking for here? would we accept design or code contributions?)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your Right we hiring nothing only just both, please linked you one white a strong develop and engineering skills. I have two autorisiert.
Copilot Pro and Jira. And we have a one Helper to. For Command Building. Tomorrow I'll try Chat GpT4 and somehow i need the Crook"3. What are you thinking about?


Before we get started, here are a few things we expect from you (and that you should expect from others):

* Be kind and thoughtful in your conversations around this project. We all come from different backgrounds and projects, which means we likely have different perspectives on "how open source is done". Try to listen to others rather than convince them that your way is correct.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"how open source is done". -> "how open source is done."


## Bug reports and security disclosures

(do we need to include for this project?)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I defer to the rest of the team.


There is also a mailing list for regular updates and discussion (link to mailing list)

Wherever possible, do not take these conversations to private channels, including contacting the maintainers directly. Not only will you stress them out, but keeping communication public means everybody can benefit and learn from the conversation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not only will you stress them out

Do we need this? It's humanizing but also starting to sound like a burden. Could we just leave it at "keeping communication public..."

@nayafia nayafia merged commit 0185c42 into gh-pages Aug 31, 2016
@nayafia nayafia deleted the contributing branch August 31, 2016 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.