Skip to content

Conversation

sramakrishnan247
Copy link

Added https://roshanjossey.github.io/first-contributions/ to finding a project to contribute to section.
This is the best place for any new developer to start. It teaches the basics of push, pull and fork by working hands on. I made my first contribution only because of this and might be useful for other newbies like me.

  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


https://roshanjossey.github.io/first-contributions/
This is the best place for any new developer to start. It teaches the basics of push, pull and fork by working hands on. I made my first contribution only because of this and might be useful for other newbies like me.
@sramakrishnan247
Copy link
Author

The failure reasons from the testing log:

The above two websites work. I have tested them personally.
Please check the issue and remove the bug.

@nayafia
Copy link
Contributor

nayafia commented Nov 9, 2017

Hi @sramakrishnan247, thanks for the suggestion! I think this fits better under the "Opening a pull request section", in this paragraph:

If this is your first pull request, check out Make a Pull Request, which kentcdodds created as a free walkthrough resource.

The website you link to doesn't seem to provide unique value beyond the other links in that list; however, I like the idea of linking to the repo which provides a visual step-by-step walkthrough and a "real" repository to try it out on. I don't think we mention any resources like that currently.

Want to add it to that paragraph above? It can go in the same sentence after Make a Pull Request. Perhaps highlight that MaPR is a video tutorial, and this is a walkthrough and repository you can practice on.

@Roshanjossey
Copy link
Contributor

@nayafia, I've submitted a pull request to address your comment. Please review.

@nayafia
Copy link
Contributor

nayafia commented Nov 21, 2017

Closed via #484.

@nayafia nayafia closed this Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants