Ebook version 0.1, closes #449#458
Ebook version 0.1, closes #449#458elbaulp wants to merge 1 commit intogithub:gh-pagesfrom elbaulp:ebook-version
Conversation
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Would be good to add CI tests to make sure that this continues to work. As a general comment I think Ruby may be better suited for this than Bash, particularly if we can't use Jekyll to e.g. remove front matter. Thanks for the PR, though!
| cd tmp | ||
| cp ../../_articles/en-US/*.md . | ||
|
|
||
| ## Remove the front matter |
There was a problem hiding this comment.
I wonder if Jekyll could be utilised to do this for us?
| @@ -0,0 +1,42 @@ | |||
| #/bin/env bash | |||
There was a problem hiding this comment.
#!/bin/bash or #!/usr/bin/env bash would be better here. Would also be good to add a set -e so errors aren't silently ignored.
There was a problem hiding this comment.
I'd even suggest:
#! /usr/bin/env bash
if [ -n "$DEBUG" ]
then
set -x
fi
set -euo pipefail
# ref: https://coderwall.com/p/fkfaqq/safer-bash-scripts-with-set-euxo-pipefail| @@ -0,0 +1,42 @@ | |||
| #/bin/env bash | |||
|
|
|||
| # Author: #elbaulp | |||
There was a problem hiding this comment.
Can skip this; the git log will reveal you are author.
| # Generate title | ||
| echo """ | ||
| --- | ||
| title: Opensource Guide |
| echo """ | ||
| --- | ||
| title: Opensource Guide | ||
| author: Github |
| --- | ||
| title: Opensource Guide | ||
| author: Github | ||
| rights: Attribution 4.0 International |
There was a problem hiding this comment.
Creative Commons Attribution 4.0 International
|
Hi @MikeMcQuaid, I don't know Ruby, I could try in python, maybe. |
|
@elbaulp Leaving it in Bash should be fine but I'd rather something like a Rubygem was installed or used in that case rather than manual |
|
Passing on this as there's been no movement in almost 2 months, sorry. |
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.
This is a first attempt, the script could be improved.