Replace ex. in guides with for example
#437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also replaced a comma with an or to help improve text flow
webknjaz
approved these changes
Aug 18, 2017
|
Hi @bvhme, thanks for this suggestion! I like this idea, as I think it will make the guides less confusing for non-native English speakers in particular. For readability purposes, could you add a comma after every
Thanks! |
|
Yes, I've done it. Please check whether this is the consistency you were thinking of, after some Googling I found out that the comma should be there in case of a list, so I've added it where there were multiples. |
|
Can this be merged? |
|
@bvhme I think it reads better with a comma after every "for example", and Googling around, it seems there isn't a hard rule to follow. "for example passwords or other non-public information" seems to be missed even following list rule. |
MikeMcQuaid
reviewed
Oct 19, 2017
_articles/en-US/best-practices.md
Outdated
| * The types of contributions you'll accept (_Do you only want help with a certain part of your code?_) | ||
| * When it's appropriate to follow up (_ex. "You can expect a response from a maintainer within 7 days. If you haven't heard anything by then, feel free to ping the thread."_) | ||
| * How much time you spend on the project (_ex. "We only spend about 5 hours per week on this project"_) | ||
| * When it's appropriate to follow up (_for example "You can expect a response from a maintainer within 7 days. If you haven't heard anything by then, feel free to ping the thread."_) |
_articles/en-US/best-practices.md
Outdated
| * When it's appropriate to follow up (_ex. "You can expect a response from a maintainer within 7 days. If you haven't heard anything by then, feel free to ping the thread."_) | ||
| * How much time you spend on the project (_ex. "We only spend about 5 hours per week on this project"_) | ||
| * When it's appropriate to follow up (_for example "You can expect a response from a maintainer within 7 days. If you haven't heard anything by then, feel free to ping the thread."_) | ||
| * How much time you spend on the project (_for example "We only spend about 5 hours per week on this project"_) |
_articles/en-US/how-to-contribute.md
Outdated
| * **[Fork the repository](https://guides.github.com/activities/forking/)** and clone it locally. Connect your local to the original "upstream" repository by adding it as a remote. Pull in changes from "upstream" often so that you stay up to date so that when you submit your pull request, merge conflicts will be less likely. (See more detailed instructions [here](https://help.github.com/articles/syncing-a-fork/).) | ||
| * **[Create a branch](https://guides.github.com/introduction/flow/)** for your edits. | ||
| * **Reference any relevant issues** or supporting documentation in your PR (ex. "Closes #37.") | ||
| * **Reference any relevant issues** or supporting documentation in your PR (for example "Closes #37.") |
| * [Thin](https://github.com/macournoyer/thin) is a fast and simple Ruby web server | ||
|
|
||
| If you're building upon an existing project, using their name as a prefix can help clarify what your project does (ex. [node-fetch](https://github.com/bitinn/node-fetch) brings `window.fetch` to Node.js). | ||
| If you're building upon an existing project, using their name as a prefix can help clarify what your project does (for example [node-fetch](https://github.com/bitinn/node-fetch) brings `window.fetch` to Node.js). |
| <input type="checkbox" id="cbox7" class="d-block float-left mt-1 mr-2" value="checkbox"> | ||
| <label for="cbox7" class="overflow-hidden d-block text-normal"> | ||
| There are no sensitive materials in the revision history, issues, or pull requests (ex. passwords or other non-public information) | ||
| There are no sensitive materials in the revision history, issues, or pull requests (for example passwords or other non-public information) |
|
Done, and done! |
MikeMcQuaid
approved these changes
Oct 20, 2017
|
Thanks for your first contribution to Open Source Guides, @bvhme! Without people like you submitting PRs we couldn't run this project. You rock! |
JAY1ne49
referenced
this pull request
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.
I was reading the guides using my screen reader and was perplexed when I heard 'ex-community'. After inspecting the letters I found the usage of a non-standard abbreviation for example with
ex.I personally feel writing out
for exampleis a lot clearer thanex..Thanks so much, love the guides!