Skip to content

fix: Get checks passing again #3434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 16, 2025
Merged

fix: Get checks passing again #3434

merged 3 commits into from
May 16, 2025

Conversation

jmeridth
Copy link
Member

@jmeridth jmeridth commented May 16, 2025

  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


  • update WHO url definition of burnout, found new url
  • ignore urls that are 403ing
  • ensure urls are using https when available

URLs 403ing:

jmeridth added 2 commits May 16, 2025 14:07
Signed-off-by: jmeridth <jmeridth@gmail.com>
- [x] also ensure all usages of it are using https

Signed-off-by: jmeridth <jmeridth@gmail.com>
@jmeridth jmeridth self-assigned this May 16, 2025
@Copilot Copilot AI review requested due to automatic review settings May 16, 2025 19:19
@jmeridth jmeridth requested a review from a team as a code owner May 16, 2025 19:19
@jmeridth jmeridth temporarily deployed to Pages Preview May 16, 2025 19:19 — with GitHub Actions Inactive
@jmeridth jmeridth temporarily deployed to Pages Preview May 16, 2025 19:20 — with GitHub Actions Inactive
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the WHO ICD URL for “burnout” across all translations and secures a Stack Overflow link in the Korean “how to contribute” guide.

  • Bumps the ICD link to the 2025-01 foundation path in all language versions
  • Converts the Stack Overflow example URL to HTTPS in ko/how-to-contribute.md

Reviewed Changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated no comments.

File Description
_articles/*/maintaining-balance-for-open-source-maintainers.md Updated WHO ICD definition URL to 2025-01 path
_articles/ko/how-to-contribute.md Switched Stack Overflow link from HTTP to HTTPS
Comments suppressed due to low confidence (4)

_articles/maintaining-balance-for-open-source-maintainers.md:13

  • The Maintainer Community link is using plain HTTP; updating it to HTTPS (https://maintainers.github.com/) will ensure all external links are served securely.
<a href="http://maintainers.github.com/">Maintainer Community</a>

_articles/ro/maintaining-balance-for-open-source-maintainers.md:13

  • This translation still links the Maintainer Community over HTTP; consider switching to HTTPS for consistency and security.
<a href="http://maintainers.github.com/">Comunidade de Mantenedores</a>

_articles/es/maintaining-balance-for-open-source-maintainers.md:14

  • [nitpick] Consider linking to the WHO ICD page in Spanish (if available) to match the article’s language and improve clarity for Spanish-speaking readers.
[definido por la OMS](https://icd.who.int/browse/2025-01/foundation/en#129180281)

_articles/ko/how-to-contribute.md:115

  • [nitpick] Good catch on HTTPS. As a best practice, verify that there are no other HTTP links (e.g., community or documentation references) remaining in this guide.
* Stack Overflow([Postgres 예시](https://stackoverflow.com/questions/18664074/getting-error-peer-authentication-failed-for-user-postgres-when-trying-to-ge))

@jmeridth
Copy link
Member Author

Seems two more urls that don't fail locally are failing in CI. Adding them for now.

@jmeridth jmeridth temporarily deployed to Pages Preview May 16, 2025 19:26 — with GitHub Actions Inactive
@jmeridth jmeridth added this pull request to the merge queue May 16, 2025
Merged via the queue into main with commit f9534cc May 16, 2025
7 checks passed
@jmeridth jmeridth deleted the jm_get_checks_passing_again branch May 16, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants