Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove script for generating ebooks #2687

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Remove script for generating ebooks #2687

merged 1 commit into from
Dec 21, 2021

Conversation

nholden
Copy link
Contributor

@nholden nholden commented Dec 20, 2021

  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


In 2017, #305 added scripts to generate ebook formats from the contents of Open Source Guides. Recently, CI started getting 403 (Forbidden) errors when trying to download the kindlegen library used by the ebook code.

It's not clear that we ever did anything with those generated ebook files, so this PR removes that code and related dependencies to get CI passing again.

@nholden nholden requested a review from a team as a code owner December 20, 2021 23:39
@nholden nholden self-assigned this Dec 20, 2021
Copy link

@octokatherine octokatherine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, that makes sense to me!

@nholden nholden merged commit 6520bc0 into main Dec 21, 2021
@nholden nholden deleted the remove-ebooks branch December 21, 2021 20:06
tonymreyes537 added a commit to tonymreyes537/opensource.guide that referenced this pull request Dec 22, 2021
commit 8dc0bae
Merge: b0a28e6 1ebe024
Author: Nick Holden <nick.r.holden@gmail.com>
Date:   Tue Dec 21 12:39:01 2021 -0800

    Merge pull request github#2685 from Deletor/main

    improving grammar

commit 1ebe024
Merge: 503728d b0a28e6
Author: Nick Holden <nick.r.holden@gmail.com>
Date:   Tue Dec 21 12:36:11 2021 -0800

    Merge branch 'main' into main

commit b0a28e6
Merge: 82d7f23 8c65189
Author: Nick Holden <nick.r.holden@gmail.com>
Date:   Tue Dec 21 12:35:43 2021 -0800

    Merge pull request github#2684 from github/dependabot-bundler-html-proofer-3.19.3

    Bump html-proofer from 3.19.2 to 3.19.3

commit 8c65189
Merge: 294623e 82d7f23
Author: Nick Holden <nick.r.holden@gmail.com>
Date:   Tue Dec 21 12:32:50 2021 -0800

    Merge branch 'main' into dependabot-bundler-html-proofer-3.19.3

commit 82d7f23
Merge: b894313 04266ab
Author: Nick Holden <nick.r.holden@gmail.com>
Date:   Tue Dec 21 12:31:01 2021 -0800

    Merge pull request github#2667 from Morion-Self/fix-spelling

    Fix spelling mistake in 'How to contribute'

commit 04266ab
Merge: c2aca18 b894313
Author: Nick Holden <nick.r.holden@gmail.com>
Date:   Tue Dec 21 12:28:15 2021 -0800

    Merge branch 'main' into fix-spelling

commit b894313
Merge: 496f2d9 cb77345
Author: Nick Holden <nick.r.holden@gmail.com>
Date:   Tue Dec 21 12:24:29 2021 -0800

    Merge pull request github#2659 from kant/patch-11

    Typo fixed (paragraph 50)

commit cb77345
Merge: ced4d34 496f2d9
Author: Nick Holden <nick.r.holden@gmail.com>
Date:   Tue Dec 21 12:21:39 2021 -0800

    Merge branch 'main' into patch-11

commit 496f2d9
Merge: 584b02d 86ab8f5
Author: Nick Holden <nick.r.holden@gmail.com>
Date:   Tue Dec 21 12:15:14 2021 -0800

    Merge pull request github#2658 from kant/patch-10

    Syntax and typos fixed

commit 503728d
Merge: 49f992f 584b02d
Author: Deletor <annco88@gmail.com>
Date:   Tue Dec 21 21:14:27 2021 +0100

    Merge branch 'github:main' into main

commit 86ab8f5
Merge: 555ef31 584b02d
Author: Nick Holden <nick.r.holden@gmail.com>
Date:   Tue Dec 21 12:12:41 2021 -0800

    Merge branch 'main' into patch-10

commit 584b02d
Merge: 6520bc0 5e46900
Author: Nick Holden <nick.r.holden@gmail.com>
Date:   Tue Dec 21 12:12:02 2021 -0800

    Merge pull request github#2656 from parroty/fix-jp-typo

    Fix typo in the starting-a-project.md (Japanese translation)

commit 49f992f
Merge: 7d78923 6520bc0
Author: Nick Holden <nick.r.holden@gmail.com>
Date:   Tue Dec 21 12:11:32 2021 -0800

    Merge branch 'main' into main

commit 294623e
Merge: 6ea27cc 6520bc0
Author: Nick Holden <nick.r.holden@gmail.com>
Date:   Tue Dec 21 12:11:20 2021 -0800

    Merge branch 'main' into dependabot-bundler-html-proofer-3.19.3

commit c2aca18
Merge: d215a2e 6520bc0
Author: Nick Holden <nick.r.holden@gmail.com>
Date:   Tue Dec 21 12:09:22 2021 -0800

    Merge branch 'main' into fix-spelling

commit ced4d34
Merge: 96fb752 6520bc0
Author: Nick Holden <nick.r.holden@gmail.com>
Date:   Tue Dec 21 12:07:37 2021 -0800

    Merge branch 'main' into patch-11

commit 555ef31
Merge: f57d6dc 6520bc0
Author: Nick Holden <nick.r.holden@gmail.com>
Date:   Tue Dec 21 12:07:24 2021 -0800

    Merge branch 'main' into patch-10

commit 5e46900
Merge: ec017a7 6520bc0
Author: Nick Holden <nick.r.holden@gmail.com>
Date:   Tue Dec 21 12:06:42 2021 -0800

    Merge branch 'main' into fix-jp-typo

commit 6520bc0
Merge: 49b7a05 89a0925
Author: Nick Holden <nick.r.holden@gmail.com>
Date:   Tue Dec 21 12:06:28 2021 -0800

    Merge pull request github#2687 from github/remove-ebooks

    Remove script for generating ebooks

commit 89a0925
Author: Nick Holden <nick.r.holden@gmail.com>
Date:   Mon Dec 20 15:35:25 2021 -0800

    Remove script for generating ebooks

commit 7d78923
Author: Deletor <annco88@gmail.com>
Date:   Mon Dec 20 18:31:01 2021 +0100

    improving grammar

commit d215a2e
Author: Marat Talipov <Morion-Self@users.noreply.github.com>
Date:   Sat Dec 11 18:52:09 2021 +0500

    Fix spelling mistakes in 'How to contribute'

commit 96fb752
Author: Darío Hereñú <magallania@gmail.com>
Date:   Thu Dec 9 15:29:43 2021 -0300

    Typo fixed (paragraph 50)

commit f57d6dc
Author: Darío Hereñú <magallania@gmail.com>
Date:   Thu Dec 9 15:24:20 2021 -0300

    Syntax issue (paragraph 74)

    - Typos fixed (paragraph 44, 106, 110, 186, 188, 214, 235)

commit ec017a7
Author: parroty <parroty00@gmail.com>
Date:   Tue Dec 7 21:41:26 2021 +0900

    Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants