puppet5

[kpaulisse]

Updates to support puppet 5.

[kpaulisse]

Hey @mschuchard - curious what you think about this one. Will the effective change of ReferenceValidationError to CatalogError in Puppet 5 cause problems with your integration? Would it be worthwhile to change the exception type for Puppet 3 and 4 to CatalogError for consistency, and get rid of ReferenceValidationError entirely?

[mschuchard]

@kpaulisse Thanks for the heads up! I understand the concept that APIs are a moving target, so don't worry about if anything breaks on my end for these changes. Since it appears you are going full on TDD for this and the tests are finished with the code to come, I can read through the code when it changes.

What I find interesting are the conditional dependencies in the .gemspec since popular notion seemed to be that kind of thing was only possible with Gemfile/Bundler.

I also got lucky and Puppet 5 seemed to change nothing with Puppet::Face so puppet-check and linter-puppet-parsing (for Atom) are both safe, except that they did put out some kind of advisory months back that people might want to stop using Puppet::Face as an API. The only reasons I recall were that it would not be supported, but I don't think that affects me.

[mschuchard]

Gave it a deep dive; thanks!