Skip to content

Conversation

@yanone
Copy link
Contributor

@yanone yanone commented Jun 20, 2024

I set up our split Roman/Italic build to land in a separate folder called /googlefonts, which are built with gftools with /sources/config.yaml.

Furthermore, I copied the "Variable Font Origin" setting from the "Exports" panel of Glyphs.app to the main font info section, because gftools doesn’t read the settings from the "Exports" panel.

Your own fonts in /fonts remain untouched by this and don't need to be rebuilt, as loosely speaking no real font data was changed.

Please merge this PR before we can proceed with the onboarding to Google Font. Thank you.

@yanone yanone requested a review from tobiasahlin as a code owner June 20, 2024 12:45
@yanone
Copy link
Contributor Author

yanone commented Jun 20, 2024

p.s. The file /sources/build.sh appears to be unused. It's not needed by us, and Sebastian also generates your builds directly from Glyphs.app which doesn't use this file. Also it references .glyphs files while the current source has an .glyphspackage extension.

In other words, I deleted it. Let me know if you want me to restore it.

@tobiasahlin
Copy link
Collaborator

@yanone excellent, thank you! We'll want to add back a standardized build script that we use outside of Google Fonts, but since build.sh is unused right now I think it makes sense to just remove it. We can cherry-pick it back in if we need it 👀

@tobiasahlin tobiasahlin merged commit 8426210 into github:main Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants