Skip to content

fix: avoid catching Promise as a side effect #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 20, 2020
Merged

fix: avoid catching Promise as a side effect #2

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60ffe5a
fix: avoid catching Promise as a side effect
keithamus Jul 17, 2020
339ead3
style: fix TS error
keithamus Jul 17, 2020
f85f509
refactor: clean up let binding with early return
keithamus Jul 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ export default function memoize<A extends unknown[], R extends unknown, T extend
return function (this: T, ...args: A) {
const id = hash.apply(this, args)
if (cache.has(id)) return cache.get(id)
const result = fn.apply(this, args)
let result = fn.apply(this, args)
if (result instanceof Promise) {
// eslint-disable-next-line github/no-then
result.catch(error => {
result = result.catch(error => {
cache.delete(id)
throw error
})
Expand Down