set outfilesuffix to match extension of input filename #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mojavelinux
commented
Apr 3, 2017
mojavelinux
commented
- set outfilesuffix to match extension of input filename
- update test for inter-document xref
- set docname attribute
- add test for docname attribute value
- pass attributes as a hash to ensure docname value is properly escaped
- set outfilesuffix to match extension of input filename - update test for inter-document xref - set docname attribute - add test for docname attribute value - pass attributes as a hash to ensure docname value is properly escaped
mojavelinux
force-pushed
the
match-outfilesuffix-to-input-file
branch
from
f72e7de
to
36b3680
Compare
mojavelinux
commented
Apr 3, 2017
| @@ -16,7 +16,7 @@ | |||
| <p>Refer to <a href="#another-section">Another Section</a> or <a href="#another-section-1">Another Section</a>.</p> | |||
| </div> | |||
| <div> | |||
| <p>Navigate to <a href="another-document.adoc">another document</a>.</p> | |||
| <p>Navigate from README.asciidoc to <a href="another-document.asciidoc">another document</a>.</p> | |||
There was a problem hiding this comment.
@kivikakk notice that the extension of referenced file now matches the extension of the file being converted.
|
Awesome. I'm just getting the internal PR to use 1.6.0 opened — once internal CI passes, I'll tag and push the gem! |
|
I'm looking forward to it! I'll inform the AsciiDoc community how to take advantage of this new functionality as soon as it's ready. 👍 |
|
Gem is pushed, and it's live on dotcom now! 🎉 |
|
Thank you! I'll sound the bells! |
|
I would like to mergre this with my main repo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.