Merged
Conversation
koddsson
approved these changes
Mar 23, 2021
Comment on lines
-209
to
-214
| it('does not codeblock selected text when using the lowercased hotkey', function () { | ||
| focus() | ||
| setVisualValue('The |quick| brown fox jumps over the lazy dog') | ||
| pressHotkey('e') // lowercase `e` instead of uppercase `E` | ||
| assert.equal('The |quick| brown fox jumps over the lazy dog', visualValue()) | ||
| }) |
Contributor
There was a problem hiding this comment.
I guess this is now covered by the casing tests that you added in #37?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After some further discussion, design would like to change the hotkey to be lowercase to match the other shortcuts in use.
So, this PR:
cmd-shift-etocmd-e(in other words, uppercaseEto lowercasee)Issue
References: https://github.com/github/special-projects/issues/135
Screenshots
Keycastr was acting up on me here, but I was pressing
⌘+e:Risk Assessment
Low risk