Feat add focus management for toolbar #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows best practices for toolbar focus management, following the guidelines available at https://www.w3.org/TR/wai-aria-practices-1.1/examples/toolbar/toolbar.html. ArrowLeft/ArrowRight will switch tabindex/focus the next and previous buttons respectively, cycling round the whole toolbar if needed. Home and End keys were also implemented.
keithamus
commented
Mar 17, 2020
muan
reviewed
Mar 17, 2020
Co-Authored-By: Mu-An 慕安 <me@muanchiou.com>
This allows non-MarkdownButtonElement instances to be part of the focus management cycle
This allows for non-MarkdownButtonElement members to also handle focus management keyboard shortcuts, as the event binding is per-toolbar not per-button
muan
reviewed
Mar 18, 2020
Co-Authored-By: Mu-An 慕安 <me@muanchiou.com>
Co-Authored-By: Mu-An 慕安 <me@muanchiou.com>
muan
reviewed
Mar 18, 2020
This catches an edge case where if the `md-*` buttons aren't upgraded before `markdown-toolbar` is, then `markdown-toolbar` will still behave correctly, as it can still select for the `md-*` buttons.
Now markdown-toolbar manages all tabindex assignment, which means it will also assign tabindexes to `data-md-button` elements, as needed.
dgraham
reviewed
Mar 24, 2020
Co-Authored-By: David Graham <dgraham@github.com>
koddsson
approved these changes
Mar 25, 2020
muan
reviewed
Mar 26, 2020
There was a problem hiding this comment.
For posterity: @keithamus and I paired this and noticed that we need a proper visibility check on the buttons for the responsive markdown toolbar items.
muan
previously approved these changes
Mar 30, 2020
muan
reviewed
Mar 30, 2020
This allows toolbars to be in an initially hidden state, and only when they are visible and focus moves to them does the focus management kick in.
Co-Authored-By: Mu-An 慕安 <me@muanchiou.com>
Co-Authored-By: Mu-An 慕安 <me@muanchiou.com>
Co-Authored-By: Mu-An 慕安 <me@muanchiou.com>
Co-Authored-By: Mu-An 慕安 <me@muanchiou.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows best practices for toolbar focus management, following the guidelines available at https://www.w3.org/TR/wai-aria-practices-1.1/examples/toolbar/toolbar.html.
ArrowLeft/ArrowRight will switch tabindex/focus the next and previous buttons respectively, cycling round the whole toolbar if needed. Home and End keys were also implemented.
Refs https://github.com/github/github/issues/133916