Skip to content

@actions/core Platform Support#138

Merged
ncalteen merged 3 commits intomainfrom
ncalteen/organization
Jan 7, 2025
Merged

@actions/core Platform Support#138
ncalteen merged 3 commits intomainfrom
ncalteen/organization

Conversation

@ncalteen
Copy link
Collaborator

@ncalteen ncalteen commented Jan 7, 2025

This PR adds support for the platform functionality in the @actions/core package.

It also organizes the stubs to more closely reflect the @actions/toolkit repository structure, so that maintaining and updating stubs is a bit less of a nuisance.

@ncalteen ncalteen self-assigned this Jan 7, 2025
Copilot AI review requested due to automatic review settings January 7, 2025 21:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 23 out of 38 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • package.json: Language not supported
  • tests/stubs/artifact/internal/find/get-artifact.test.ts: Evaluated as low risk
  • tests/stubs/artifact/internal/shared/config.test.ts: Evaluated as low risk
  • tests/index.test.ts: Evaluated as low risk
  • tests/command.test.ts: Evaluated as low risk
  • tests/stubs/artifact/internal/shared/user-agent.test.ts: Evaluated as low risk
  • tests/commands/run.test.ts: Evaluated as low risk
  • tests/stubs/env.test.ts: Evaluated as low risk
  • tests/utils/output.test.ts: Evaluated as low risk
  • tests/stubs/artifact/internal/delete/delete-artifact.test.ts: Evaluated as low risk
  • tests/stubs/artifact/internal/download/download-artifact.test.ts: Evaluated as low risk
  • tests/stubs/artifact/internal/client.test.ts: Evaluated as low risk
  • tests/stubs/core/summary.test.ts: Evaluated as low risk
  • tests/stubs/artifact/internal/upload/upload-artifact.test.ts: Evaluated as low risk
  • tests/stubs/artifact/internal/find/list-artifacts.test.ts: Evaluated as low risk
Comments suppressed due to low confidence (2)

tests/stubs/core/path-utils.test.ts:6

  • The function 'toPosixPath' should have its own dedicated test case to ensure comprehensive test coverage.
toPosixPath,

tests/stubs/core/core.test.ts:597

  • The tests for toPosixPath, toWin32Path, and toPlatformPath have been removed. Ensure these functions are covered by tests elsewhere if they are still relevant.
describe('toPosixPath()', () => {

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

@github-actions
Copy link

github-actions bot commented Jan 7, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 4 0 0.07s
✅ JAVASCRIPT prettier 11 0 1.38s
✅ JSON jsonlint 23 0 0.63s
✅ JSON npm-package-json-lint yes no 3.24s
✅ JSON prettier 23 0 2.11s
✅ MARKDOWN markdownlint 8 0 0.84s
✅ REPOSITORY checkov yes no 23.91s
✅ REPOSITORY gitleaks yes no 1.06s
✅ REPOSITORY git_diff yes no 0.03s
✅ REPOSITORY grype yes no 23.49s
✅ REPOSITORY secretlint yes no 1.02s
✅ REPOSITORY trivy yes no 9.78s
✅ REPOSITORY trivy-sbom yes no 1.06s
✅ REPOSITORY trufflehog yes no 28.71s
✅ TYPESCRIPT prettier 60 0 4.58s
✅ YAML prettier 21 0 1.14s
✅ YAML yamllint 21 0 0.96s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@ncalteen ncalteen merged commit 6b7a9eb into main Jan 7, 2025
4 checks passed
@ncalteen ncalteen deleted the ncalteen/organization branch January 7, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants