Skip to content

Conversation

@ShaneMalachow
Copy link
Contributor

Resolving #90

Simply checks the GITHUB_SERVER_URL environment variable, if it's set to github.com it will use the default login, otherwise it uses the GitHub Enterprise Server specific connection function.

Validated against my company's GitHub Enterprise Server instance, can't really show the output because of the proprietary nature of how the logs look. If there's a good bit of evidence you want for that that I can provide, let me know.

@ShaneMalachow ShaneMalachow requested a review from zkoppert as a code owner August 2, 2023 18:04
@zkoppert zkoppert added the enhancement New feature or request label Aug 2, 2023
Co-authored-by: Zack Koppert <zkoppert@github.com>
Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this and doing the testing as well! 🎉 Appreciate it! I plan to create a release later today.

@zkoppert zkoppert merged commit 6eea04d into github:main Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants