Skip to content

Conversation

@Okabe-Junya
Copy link
Contributor

@Okabe-Junya Okabe-Junya commented Jul 31, 2023

ref. #79

WHAT I CHANGED

  • Escape vertical-bar character when Creating markdown table
  • Add test case for testing escape character

HOW IMPLEMENTED

| is another way to represent vertical lines in html. It can therefore be implemented by replacing characters during markdown generation.

ADDITIONAL INFO

Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for including the test!

@zkoppert zkoppert merged commit 116795c into github:main Jul 31, 2023
@Okabe-Junya Okabe-Junya deleted the junya/feat/escape-vertical-bar branch July 31, 2023 16:44
@zkoppert
Copy link
Member

Thanks a lot for taking the time to contribute this! Really appreciate it. I will publish a release later today.

@Okabe-Junya
Copy link
Contributor Author

My pleasure!! Thank you as well for the wonderful CI workflow.

As I have some time to contribute during my summer vacation, I might be able to contribute to other issues as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants