fix: use GitHub App token when authed with GitHub App #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we are still trying to use the GH_TOKEN env var when making api/graphql calls even after authenticating with a GitHub App Installation. This change fixes that. Also fixed a few other things while in here: - [x] split authentication to auth.py file (like other actions) - [x] fix arguments to the count_comments_per_user function - [x] add `maintenance` to pull request template Signed-off-by: jmeridth <jmeridth@gmail.com>
jmeridth
force-pushed
the
jm-use-app-token-in-graphql-when-using-github-app
branch
from
c031a96 to
1f04c74
Compare
Signed-off-by: Zack Koppert <zkoppert@github.com>
zkoppert
reviewed
Apr 29, 2024
| ignore_users, | ||
| None, | ||
| None, | ||
| ignore_users, |
There was a problem hiding this comment.
uh oh. This should have been caught by a test. Added one at 79a3995
There was a problem hiding this comment.
local linting caught it for me. mypy ftw. excellent idea to add tests. thank you.
There was a problem hiding this comment.
Is mypy disabled in our super-linter? Wondering how this status check passed so we could merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Proposed Changes
Currently we are still trying to use the GH_TOKEN env var when making api/graphql calls even after authenticating with a GitHub App Installation. This change fixes that.
Also fixed a few other things while in here:
Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducingReviewer
fix,documentation,enhancement,infrastructure,maintenance, orbreaking