Skip to content

Conversation

@jmeridth
Copy link
Member

@jmeridth jmeridth commented Apr 18, 2024

Part of github/github-ospo#78

Auto-labelling will fail since it's config is not in the default branch to start. After this merge it will work (tested in github/cleanowners#52)

Pull Request

Proposed Changes

  • lint pr title adhering to conventional commits (helps with auto labelling)
    • Update CONTRIBUTING.md
      • automated releases
      • how to file a bug report
      • how to file an enhancement
    • Update pull_request_template with new standard
  • setup autolabelling through release-drafter github action config
  • create auto-labeler workflow
  • change release-drafter workflow to release
    • create release, including new tag
    • create discussion announcement based on release
    • build container images, tag them and release them

Manual Actions:

  • create revert and maintenance labels
  • put repository and category IDs into secrets for the discussion create action

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, or breaking

@jmeridth jmeridth self-assigned this Apr 18, 2024
@jmeridth jmeridth requested a review from zkoppert as a code owner April 18, 2024 19:47
@jmeridth jmeridth added the enhancement New feature or request label Apr 18, 2024
@jmeridth jmeridth marked this pull request as draft April 18, 2024 19:49
- [x] lint pr title adhering to conventional commits (helps with auto labelling)
  - [x] Update CONTRIBUTING.md
    - [x] automated releases
    - [x] how to file a bug report
    - [x] how to file an enhancement
  - [x] Update pull_request_template with new standard
- [x] setup autolabelling through release-drafter github action config
- [x] create auto-labeler workflow
- [x] change release-drafter workflow to release
  - [x] create release, including new tag
  - [x] create discussion announcement based on release
  - [x] build container images, tag them and release them

Signed-off-by: jmeridth <jmeridth@gmail.com>
@jmeridth jmeridth force-pushed the jm-automated-releases-and-autolabelling branch from f845f0d to cb7c447 Compare April 19, 2024 15:12
@jmeridth jmeridth marked this pull request as ready for review April 19, 2024 15:18
@zkoppert
Copy link
Member

🤔 Is it concerning the auto-labeler didn't fail? I wonder if it would pass if you reran the job. 😕

Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jmeridth jmeridth merged commit d33a996 into main Apr 19, 2024
@jmeridth jmeridth deleted the jm-automated-releases-and-autolabelling branch April 19, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants