Skip to content

Conversation

@jmeridth
Copy link
Member

@jmeridth jmeridth commented Apr 17, 2024

Pull Request

Proposed Changes

Helps us merge #240

  • ensure always exit code 0
  • include list to exclude
    • they do not have the alternative to include (that list would be *.py)

We have a duplicate clone in labels.py right now but beyond the scope of this change IMO

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, or breaking

- [x] ensure always exit code 0
- [x] include list to exclude
  - they do not have the alternative to include (that list would be *.py)

We have a duplicate clone in labels.py right now but beyond the scope of this change IMO

Signed-off-by: jmeridth <jmeridth@gmail.com>
@jmeridth jmeridth added the bug Something isn't working label Apr 17, 2024
@jmeridth jmeridth self-assigned this Apr 17, 2024
@jmeridth jmeridth requested a review from zkoppert as a code owner April 17, 2024 18:41
@jmeridth jmeridth merged commit b6893ac into main Apr 18, 2024
@jmeridth jmeridth deleted the jm-duplication-linting-is-nonblocking branch April 18, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants