Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Drupal.gitignore #3773

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update Drupal.gitignore #3773

wants to merge 1 commit into from

Conversation

zhouhana
Copy link

Reasons for making this change:

This template is also valid for Drupal 9. As a matter of fact, when starting new projects you should use Drupal 9. And 8 is only supported until November 2021.

Links to documentation supporting these rule changes:

https://www.drupal.org/project/drupal

@bdougie
Copy link
Contributor

bdougie commented Aug 18, 2021

Would it be preferred to remove the version number altogether? https://github.com/github/gitignore#versioned-templates

@zhouhana
Copy link
Author

zhouhana commented Nov 30, 2021

Drupal 7 and earlier versions has different needs for the .gitignore than Drupal 8 and later. So maybe it should say

# gitignore template for Drupal 8 and later

or

# gitignore template for version 8 and later of the Drupal project

or similar.

@bdougie
Copy link
Contributor

bdougie commented Dec 11, 2021

gitignore template for Drupal 8 and later
This is preferred. Is it also safe to assume that new Drupal projects will be Drupal 8 or later?

@bdougie
Copy link
Contributor

bdougie commented Dec 11, 2021

Linking other Drupal PRs #3386 #3386

@lpalgarvio
Copy link
Contributor

lpalgarvio commented Dec 12, 2021

the structure is expected to be roughly the same in 8 vs 9, so the comment change should suffice

but perhaps #3914 should be reworked to consider #3386 and update paths if there are any official changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants