Add .externalNativeBuild to Android gitignore #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This really should be in the Android gitignore! |
|
Absolutely should be. It's documented and the default AS .gitignore includes it now. Github's gitignore list is now out of date for Android. |
|
Is anything wrong for this PR don't get merged? |
|
Nothing at all as far as I can tell, I provided ample documentation for the fact that this is now recommended to be included. Github is just ignoring this PR. |
|
Maybe they missed this PR. |
|
@4brunu @kevinmost thanks for this! |
u9E9F
pushed a commit
to u9E9F/gitignore
that referenced
this pull request
Jul 8, 2017
…uild Add .externalNativeBuild to Android gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change:
As of Android Studio 2.2 Preview 6, the default .gitignore generated for a project includes this file.
Links to documentation supporting these rule changes:
https://sites.google.com/a/android.com/tools/tech-docs/external-c-builds#TOC-Release-History