Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding artifacts and project.lock.json for asp.net 5 #1505

Merged
merged 1 commit into from
May 6, 2015

Conversation

sayedihashimi
Copy link
Contributor

I've added the following to VisualStudio.gitignore to support ASP.NET 5

# ASP.NET 5
project.lock.json
artifacts/

project.lock.json is created by default whenever a restore operation is executed. It should be ignored by default.

The artifacts folder will contain build output, and likely should never be checked in.

Note: I'm on the team that works on Visual Studio for ASP.NET

@shiftkey
Copy link
Member

shiftkey commented May 6, 2015

@sayedihashimi all good (just saw the Twitter discussion about it as well).

shiftkey added a commit that referenced this pull request May 6, 2015
adding artifacts and project.lock.json for asp.net 5
@shiftkey shiftkey merged commit c7019d8 into github:master May 6, 2015
@damianh
Copy link
Contributor

damianh commented May 7, 2015

Istead of # ASP.NET 5, perhaps # DNX?

@shiftkey
Copy link
Member

shiftkey commented May 7, 2015

@damianh - maybe? who owns that these days?

@damianh
Copy link
Contributor

damianh commented May 7, 2015

DNX shizzle came from asp.net team but it is independent of HTTP things.
It appears to be moving towards CoreClr folk atm.
https://github.com/dotnet/coreclr
On 7 May 2015 10:01, "Brendan Forster" notifications@github.com wrote:

@damianh https://github.com/damianh - maybe? who owns that these days?


Reply to this email directly or view it on GitHub
#1505 (comment).

@shiftkey
Copy link
Member

shiftkey commented May 7, 2015

@damianh if someone wants to amend this I'll happily take the change...

@sayedihashimi
Copy link
Contributor Author

Yes sorry dnx is better, sorry about that. I'm not at a computer at the moment.

@damianh
Copy link
Contributor

damianh commented May 8, 2015

No worries!

Yolo PR done and sent from phone ;)
On 8 May 2015 00:45, "Sayed Ibrahim Hashimi" notifications@github.com
wrote:

Yes sorry dnx is better, sorry about that. I'm not at a computer at the
moment.


Reply to this email directly or view it on GitHub
#1505 (comment).

u9E9F pushed a commit to u9E9F/gitignore that referenced this pull request Jul 8, 2017
adding artifacts and project.lock.json for asp.net 5
u9E9F pushed a commit to u9E9F/gitignore that referenced this pull request Jul 8, 2017
As discussed in github#1505
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants