chore: correct build arg syntax #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to correct the build arg syntax used in the GitHub Actions workflow for Docker image publishing.
- Changed the build-args configuration from a YAML mapping to a multiline string.
Tip: Leave feedback on Copilot's review comments with the 👎 and 👍 buttons to help improve review quality. Learn more
Comment on lines
+83
to
+84
| build-args: | | ||
| VERSION=${{ github.ref_name }} |
There was a problem hiding this comment.
The new multiline string syntax changes the data type for build-args from a mapping to a string. Please verify that this syntax is supported by the Docker build action; otherwise, reverting to the original mapping format (using key-value pairs) might be necessary.
Suggested change
| build-args: | | |
| VERSION=${{ github.ref_name }} | |
| build-args: | |
| VERSION: ${{ github.ref_name }} |
manian0430
pushed a commit
to ChrisLally/github-mcp-server
that referenced
this pull request
Apr 12, 2025
DaleSeo
pushed a commit
to DaleSeo/github-mcp-server
that referenced
this pull request
Oct 24, 2025
Co-authored-by: Karthik KK <karthik@techgeek.co.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.