simplify environment var with same format UPPERCASE and UNDERSCORE #663
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>
hungran
changed the title
There was a problem hiding this comment.
Pull Request Overview
Enhance Viper configuration to allow flag names with hyphens to be consumed as environment variables by replacing hyphens with underscores.
- Configure Viper to replace
-with_in env var keys. - Call
viper.SetEnvKeyReplacerbeforeviper.AutomaticEnv().
Comments suppressed due to low confidence (1)
cmd/github-mcp-server/main.go:96
- Consider adding a unit test for initConfig to verify that environment variables with hyphens (e.g., 'dynamic-toolsets') are correctly mapped to underscore format (e.g., 'GITHUB_DYNAMIC_TOOLSETS').
viper.SetEnvKeyReplacer(strings.NewReplacer("-", "_"))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes:
This enhance that all argument can be treat as environment variable with standard format from viper https://github.com/spf13/viper/blob/master/viper.go#L1400-L1403
eg: given argument flag
dynamic-toolsetscan use asGITHUB_DYNAMIC_TOOLSETS