Skip to content

Remove test that can panic #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
williammartin merged 2 commits into from
May 27, 2025
Merged

Remove test that can panic #445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bb3f88
Remove test that can panic
williammartin May 27, 2025
ecb82d1
Fix incorrect repo resource table test
williammartin May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/github/repository_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@ func RepositoryResourceContentsHandler(getClient GetClientFn) func(ctx context.C
}
}

// This should be unreachable because GetContents should return an error if neither file nor directory content is found.
return nil, errors.New("no repository resource content found")
}
}
18 changes: 1 addition & 17 deletions pkg/github/repository_resource_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ func Test_repositoryResourceContentsHandler(t *testing.T) {
requestArgs map[string]any
expectError string
expectedResult any
expectedErrMsg string
}{
{
name: "missing owner",
Expand Down Expand Up @@ -180,21 +179,6 @@ func Test_repositoryResourceContentsHandler(t *testing.T) {
},
expectedResult: expectedDirContent,
},
{
name: "no data",
mockedClient: mock.NewMockedHTTPClient(
mock.WithRequestMatch(
mock.GetReposContentsByOwnerByRepoByPath,
),
),
requestArgs: map[string]any{
"owner": []string{"owner"},
"repo": []string{"repo"},
"path": []string{"src"},
},
expectedResult: nil,
expectError: "no repository resource content found",
Copy link
Collaborator Author

@williammartin williammartin May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this expectError field is never actually used because all the tests set expectedErrorMsg.

Copy link
Collaborator Author

@williammartin williammartin May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed now in https://github.com/github/github-mcp-server/pull/445/files#diff-134064f0cd858eb16a795df5143e87363a3ac3bb4c6a58beddf2dbf1fd689ec3R235-R236

},
{
name: "empty data",
mockedClient: mock.NewMockedHTTPClient(
Expand Down Expand Up @@ -248,7 +232,7 @@ func Test_repositoryResourceContentsHandler(t *testing.T) {
resp, err := handler(context.TODO(), request)

if tc.expectError != "" {
require.ErrorContains(t, err, tc.expectedErrMsg)
require.ErrorContains(t, err, tc.expectError)
return
}

Expand Down