Prefer already-defined endpoint mock #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshorty
requested review from
SamMorrowDrums,
juruen,
toby and
williammartin
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the test for GetCommit to use the pre-defined endpoint pattern from the mock package, eliminating the redundant manual definition.
- Removed the manually defined endpoint pattern.
- Replaced its usage with mock.GetReposCommitsByOwnerByRepoByRef in test cases.
juruen
approved these changes
Apr 11, 2025
Collaborator
juruen
left a comment
juruen
left a comment
There was a problem hiding this comment.
I missed that too, sorry!
nickytonline
pushed a commit
to nickytonline/github-mcp-http
that referenced
this pull request
Oct 4, 2025
DaleSeo
pushed a commit
to DaleSeo/github-mcp-server
that referenced
this pull request
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went to cut a PR upstream and realized I missed this pre-defined endpoint pattern when checking for work on #216.