Subgroup Member Search strategy optimizations #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return entries_by_uid(uids) if uids.any? | ||
|
|
||
| # track group | ||
| searched << group.dn |
There was a problem hiding this comment.
From what I can tell, searched tracks DNs for groups, members, and subgroups. Maybe a better explanation or variable name here?
|
What's attrs in find_groups_by_dn? Looks like you extracted and forgot to carry that over? |
|
I didn't try running this, but I'm guessing there's test coverage on the existing behavior? |
mtodd
added a commit
that referenced
this pull request
Jan 20, 2015
Subgroup Member Search strategy optimizations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the Recursive Member Search strategy to search for subgroups and then materialize members (without search).
This still performs a search for every member, but filters for group objects only. Once all of the groups have been identified (respecting the max
depthoption), we take the subgroups' members and materialize them intoNet::LDAP::Entryobjects (just wrapping thedn).cc @jch