Simplify Search Strategy configuration, detection, default behavior #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You forgot to remove detect_test.rb Otherwise 👍 whenever the build is green. |
mtodd
added a commit
that referenced
this pull request
Dec 6, 2014
Simplify Search Strategy configuration, detection, default behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
Detectmeta-strategies for the Member Search and Membership Validation behaviors. Inlines the configuration and detection logic inGitHub::Ldapinstantiation/configuration, simplifying things drastically. Combines the separate config options intosearch_strategy.This is to follow up on #69, specifically addressing concerns @jch brought up, summarized here: #69 (comment)
cc @jch @github/ldap