Recursive memberOf group search strategy #66
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| entries.each_with_object(entries.dup) do |entry, entries| | ||
| entries.concat search_strategy.perform(entry) | ||
| end.select { |entry| group?(entry) } |
There was a problem hiding this comment.
This looks pretty innocuous, but it can result in N_M *recursive_ queries and exceptionally bad performance for large data sets.
It might make more sense to inline the relevant logic from the search strategy in order to recursively search for multiple entries at a given time (instead of individually). This warrants more consideration and testing.
|
This won't be making it into the imminent release, 1.6.0. |
|
Closing as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion to the recursive member search strategy introduced in #64 which searches for the groups an entry is a member of.
There isn't really a classic strategy here other than to just search for the direct memberships without recursing to find subgroups the entry is a member of.
Going to follow up after this is merged to clean up and bring this and #64 functionality into a more consistent interface.
cc @jch @github/ldap