Local ActiveDirectory integration testing #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
| admin_user: ENV.fetch("ACTIVEDIRECTORY_USER"), | ||
| admin_password: ENV.fetch("ACTIVEDIRECTORY_PASSWORD"), | ||
| search_domains: ENV.fetch("ACTIVEDIRECTORY_SEARCH_DOMAINS"), | ||
| instrumentation_service: @service |
There was a problem hiding this comment.
We might be able to make this generic using INTEGRATION_HOST et al.
|
Like how this is handled considering our situation with TravisCI and AD! |
| ```sh | ||
| $ cp test/support/vm/activedirectory/env.sh{.example,} | ||
|
|
||
| # edit ad-env.sh and fill in with your VM's values, then |
There was a problem hiding this comment.
ad-env.sh should probably be activedirectory/env.sh right?
|
@jch taking this over so I can merge it and get 1.5 released. |
|
@jch wanna take a quick look at this to make sure it makes sense. |
mtodd
added a commit
that referenced
this pull request
Nov 14, 2014
…testing Local ActiveDirectory integration testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're unable to run ActiveDirectory in CI at this time, so I documented how to run tests against a local AD instance. I also added additional tests for the AD membership validator. Assuming a similar seed file is loaded into AD, we'll be able to run these tests locally.
cc @mtodd @jameswhite