Add CI build for OpenLDAP integration #48
Conversation
|
Tests are failing due to the mismatch of fixture data. My original strategy was to create separate tests for OpenLDAP but I think a better approach will be to update the existing tests and fixtures to match OpenLDAP fixtures (which will also need to be expanded to include existing cases). Also worth noting, OpenLDAP tests run in under 30s, compared to 2min 30sec runtime for ApacheDS-based tests due to it frequently booting and terminating its test server! |
|
Then again, we could cut down the tests we run for OpenLDAP and follow up by bigger refactoring of tests in a separate PR. |
This is to reduce the variations each test creates, so all tests can pass with the same settings, fixtures.
Overrides local adaptor settings, though.
Helpful for debugging since quiet will override verbose in practice.
The original posixGroup schema was mostly made up, so this duplicates the reference: http://www.zytrax.com/books/ldap/ape/nis.html
|
Merging without the Vagrant box for testing OpenLDAP locally, will follow up separately. |
Add CI build for OpenLDAP integration
| set -e | ||
| set -x | ||
|
|
||
| cd `dirname $0`/.. |
There was a problem hiding this comment.
Travis doesn't run scripts from the project root?
|
👍 left some small nitpicks inline, but awesome stuff overall |
|
@jch yeah, the |
Reopening #47 against
dev-v2since this is targeting v2.0 release.Early work to add tests using OpenLDAP for #46.
cc @jch