Enable contributions from Windows developers #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables Windows developers to contribute to the project by updating the contribution guidelines.
- Updated dependency installation instructions with platform-specific commands.
- Added separate commands for running tests on Unix-like and Windows systems.
Files not reviewed (4)
- Makefile.win: Language not supported
- script/bootstrap.ps1: Language not supported
- script/ensure-go-installed.ps1: Language not supported
- script/go.ps1: Language not supported
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
cc: @ttaylorr |
mhagger
reviewed
Apr 3, 2025
Makefile.win
Outdated
|
|
||
| # Help target | ||
| help: | ||
| @powershell -NoProfile -ExecutionPolicy Bypass -Command "Write-Host 'Windows Makefile for git-sizer' -ForegroundColor Cyan" |
There was a problem hiding this comment.
Is there an easier way to make powershell be used for all commands rather than having to write them all out like this? Glancing at the GNU make docs, maybe setting MAKESHELL would do something like that?
There was a problem hiding this comment.
Thanks for the pointer... just cleaned that up with a variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Windows developers to contribute to the project. It includes PowerShell-equivalent scripts the bash scripts that set up prerequisites and dependencies, as well as a Windows-specific Makefile that uses PowerShell to execute its steps.