Conversation
It wasn't used.
This provides a better separation of concerns, which will be taken advantage of shortly.
We want to add another type of root, so start the virtualization process.
Instead of only traversing objects starting at references, allow the user to specify explicit Git objects via the command line. In that case, the traversal includes objects reachable from those objects.
|
Sweet! |
elhmn
previously approved these changes
Aug 16, 2023
Member
Author
I just pushed a commit to fix the linter problem. @elhmn: if you're OK with the change, feel free to merge this. @elhmn and I also discussed that this should probably not bother scanning references at all or reporting their counts when run in "explicit-root-only" mode. He's going to take a stab at implementing that change. Feel free to implement it as part of this PR or to merge this one and implement it as part of a separate PR. |
elhmn
approved these changes
Aug 22, 2023
blmitkc
approved these changes
Dec 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have you ever wanted to compute
git-sizerstats for a particular part of your history, for example a single tree? This PR implements that feature.git-sizernow allows arbitrary ROOT argument, likewhich would show the stats for the whole source tree of the
maincommit, but for no other commits. If at least one ROOT argument is specified, then the usual behavior of scanning references doesn't happen, unless you also specify options to select references, likewhich would include all references, plus the previous version of branch
main(which might give different results if, for example,mainjust had a non-fast-forward update).The new ROOT objects will also be used (in the form that they appeared in the command-line) in the names that are shown in the footnotes.
/cc @elhmn, @vtbassmatt