Skip to content

Running 'make test' dies due to no .git when building from a .tar.gz #51

Description

@avar

If you follow these build instructions and run make test on one of the .tar.gz releases you get:

$ make test; echo $?
[...]
        Messages:       command failed; output: "error: couldn't open Git repository: git rev-parse failed: fatal: not a git repository (or any of the parent directories): .git\n\n"
[...]
make: *** [gotest] Error 1
2

Just running git init in the build directory works around it, but I don't know how much this breaks the tests, if at all:

$ make test; echo $?
[...]
ok      github.com/github/git-sizer     0.123s
ok      github.com/github/git-sizer/counts      (cached)
?       github.com/github/git-sizer/git [no test files]
?       github.com/github/git-sizer/isatty      [no test files]
?       github.com/github/git-sizer/meter       [no test files]
?       github.com/github/git-sizer/sizes       [no test files]
0

So now I do git init in my packaging script, but it would be neat if this worked out of the box.

Activity

  1. mhagger commented on Nov 20, 2018

    @mhagger
    Member

    Hmmm, good point. We should really supply a test repo explicitly rather than leaning on the git-sizer repo, for example by generating it programmatically or in the form of a git fast-import input file. Until somebody does that, it might make sense to disable that test when no .git directory is present to reduce confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions