Unified tz solution #269
Merged
Unified tz solution #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 25 commits
September 28, 2016 09:44
… converts datetime to timestamp
…ased on global timze_zone
--time-zone overrides both of them, if given
…lar the conversion from DATETIME to TIMESTAMP
…TIMESTAMP conversion
also refactored some functions
…ed legacy comments
| for _, column := range columns.Columns() { | ||
| var setToken string | ||
| if column.timezoneConversion != nil { | ||
| setToken = fmt.Sprintf("%s=convert_tz(?, '%s', '%s')", EscapeName(column.Name), column.timezoneConversion.ToTimezone, "+00:00") |
Contributor
There was a problem hiding this comment.
Nice, glad this works 👍
Contributor
Author
|
Added a (enforced, tested) limitation that a column converting from |
Contributor
Author
|
Sent to production testing |
Contributor
Author
|
Tests are good. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storyline: #247
This PR identifies and solves the very special case where a
DATETIMEcolumns is converted toTIMESTAMP. Turns out it is a different case from any otherDATETIME/TIMESTAMPrelated conversion.The PR fixes handling of this migration cross different timezones; it will behave correctly even as master, replica and app are all on different time zones.
This PR adds a lot of time-related tests.