Skip to content

Revert "Bump actions/setup-dotnet from 1 to 3" #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert "Bump actions/setup-dotnet from 1 to 3" #1043

wants to merge 1 commit into from

Conversation

timrogers
Copy link
Contributor

Reverts #937

We're reverting this because we've seen dotnet format sporadically failing since the upgrade.

@dylan-smith
Copy link
Collaborator

I think you rolled back the wrong PR.

There was PR #937 , then that was rolled back in PR #940

Then we did PR #949 which is the one we should be rolling back now.

@timrogers
Copy link
Contributor Author

😅 Thanks! I'm sure 1.0 would be fine too, but a newer version is nicer.

@timrogers timrogers closed this Jun 26, 2023
@dylan-smith
Copy link
Collaborator

The main difference being that v2 was working. Also not sure if that globals.json file introduced in #949 is part of the problem or not.

@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
gei 81% 75% 538 ✔
ado2gh 84% 82% 617 ✔
bbs2gh 79% 76% 665 ✔
Octoshift 86% 75% 1182 ✔
Summary 83% (6517 / 7809) 77% (1547 / 2016) 3002 ✔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timrogers @dylan-smith