Add JSON schema validation for MCP gateway configuration (--validate flag) #9839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot stopped work on behalf of
pelikhan due to an error
January 13, 2026 15:19
pelikhan
reviewed
Jan 13, 2026
pkg/workflow/mcp_renderer.go
Outdated
| // This catches compiler bugs that generate invalid configurations | ||
| // Note: We need to clean up the indentation and substitute variables for validation | ||
| configForValidation := prepareConfigForValidation(generatedConfig) | ||
| if err := ValidateMCPGatewayConfig(configForValidation); err != nil { |
Contributor
There was a problem hiding this comment.
@copilot should only happen with --validate flag enabled
- Add SkipValidation flag to JSONMCPConfigOptions struct - Pass compiler's skipValidation flag through WorkflowData - Validation only runs when --validate flag is enabled - Embed MCP gateway schema in pkg/workflow/schemas/ - Update all engine implementations to pass SkipValidation flag - Update tests to skip validation Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add JSON schema validation for MCP gateway configuration
Add JSON schema validation for MCP gateway configuration (--validate flag)
Jan 13, 2026
Contributor
|
@copilot merge main, format, lint, review code |
…-schema-configuration
- Merge main branch - Recompile all workflow files - Fix staticcheck QF1012: Use WriteString instead of fmt.Fprintf for simple strings Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Contributor
|
@copilot investigate the build failures and fix compiler so that the agentic workflows compile (fix the compiler) |
- Add nil checks for workflowData before accessing CompilerSkipValidation - Fix logic: skip validation when workflowData is nil OR flag is not set OR flag is true - Update TestCustomEngineRenderMCPConfig to match new output format - All MCP-related tests now pass Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Fixed the build failure. The issue was a nil pointer dereference when accessing Changes in commit 2f8199f:
Verification:
|
Contributor
|
@copilot merge main, format, lint go |
…-schema-configuration
- Merge latest changes from main branch - Format all code with make fmt - Lint Go code with make lint (all checks pass) - Recompile all 121 workflow files Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Contributor
|
@copilot recompile workflows and report results if they all validate |
Copilot stopped work on behalf of
pelikhan due to an error
January 13, 2026 17:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MCP Gateway Configuration JSON Schema Validation
This PR adds JSON schema validation for MCP gateway configurations before they are sent to the gateway script, ensuring the compiler generates correct configurations. Validation only runs when the
--validateflag is enabled.Plan
Key Changes
New file:
pkg/workflow/mcp_gateway_schema_validation.goValidateMCPGatewayConfig()functionUpdate:
pkg/workflow/mcp_renderer.goSkipValidationflag toJSONMCPConfigOptionsstructUpdate: All engines (copilot, claude, codex, custom)
SkipValidationflag through optionsskipValidationsettingUpdate:
pkg/workflow/compiler_types.goCompilerSkipValidationfield toWorkflowDatato pass flag from compiler to enginesBehavior
Testing
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.